Skip to content

Fix Filter submenu sizing - #8467

Open
jonathanawesome wants to merge 7 commits into
mainfrom
fix-submenu-sizing
Open

Fix Filter submenu sizing#8467
jonathanawesome wants to merge 7 commits into
mainfrom
fix-submenu-sizing

Conversation

@jonathanawesome

@jonathanawesome jonathanawesome commented Sep 11, 2026

Copy link
Copy Markdown
Member

This PR primarily fixes an issue in our Menu/FilterMenu component where a submenu that is awaiting data computes width before the data arrives, causing a possible mismatch to the proper width.

  • removes stableWidth from Menu
  • restores submenu chevrons
  • added close-submenus-on-scroll so the submenu doesn't scroll along
  • adds foundry previews mimicking console usage of FilterMenu with simulated loading
  • locks body scroll when menus are open

@theguild-bot

theguild-bot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 11.14.0-alpha-20260914165315-d7562a950720603567ef73f32f38aa70296a7c4d npm ↗︎ unpkg ↗︎

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tags: 11.14.0-alpha-d7562a9, d7562a9, d7562a950720603567ef73f32f38aa70296a7c4d

@jdolle jdolle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor visual issue where the top element in a menu has a top margin but the bottom element doesnt have a bottom margin (see screenshot). Otherwise looks good

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants